Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve application configuration #171

Merged
merged 18 commits into from
Jan 1, 2021
Merged

Improve application configuration #171

merged 18 commits into from
Jan 1, 2021

Conversation

lilioid
Copy link
Member

@lilioid lilioid commented Dec 9, 2020

closes #152

@lilioid lilioid force-pushed the feature/better_configuration branch from d9bb0ce to 6b679fe Compare December 9, 2020 14:51
@lilioid lilioid force-pushed the feature/better_configuration branch from 2c5e710 to de0fdc5 Compare December 9, 2020 18:00
@lilioid lilioid force-pushed the feature/better_configuration branch from de0fdc5 to bee1917 Compare December 9, 2020 18:01
@lilioid lilioid marked this pull request as ready for review December 9, 2020 18:22
@lilioid lilioid requested a review from timonegk December 9, 2020 18:22
@lilioid lilioid self-assigned this Dec 9, 2020
@lilioid lilioid requested a review from timonegk December 10, 2020 09:32
@lilioid lilioid force-pushed the feature/better_configuration branch from ff8ed69 to ac6896d Compare December 10, 2020 09:43
@timonegk
Copy link
Member

With all the configuration and setup changes, please remember to update the README.

@lilioid lilioid force-pushed the feature/better_configuration branch 6 times, most recently from 4cd4697 to a59d05e Compare December 10, 2020 13:43
@lilioid lilioid force-pushed the feature/better_configuration branch from a59d05e to 904d89a Compare December 10, 2020 13:44
@lilioid
Copy link
Member Author

lilioid commented Dec 10, 2020

I sincerely apologize for all the force pushes. I was arguing with codacy and everything should be alright now…

timonegk
timonegk requested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@timonegk timonegk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would tag this commit with v0.6 since some new features and fixes have been added since the last release. Then, upgrade instructions from v0.5 should be added to UPGRADE.md.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
imagetagger/imagetagger/settings.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
timonegk
timonegk requested changes Dec 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
imagetagger/imagetagger/settings.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
jaagut
jaagut reviewed Dec 17, 2020
View reviewed changes
README.md Show resolved Hide resolved
@lilioid lilioid requested a review from timonegk December 18, 2020 11:06
@lilioid lilioid force-pushed the feature/better_configuration branch from faab197 to 1f855fc Compare December 18, 2020 11:10
timonegk
timonegk requested changes Dec 31, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jaagut jaagut requested a review from timonegk December 31, 2020 18:08
@timonegk timonegk merged commit c97c39e into master Jan 1, 2021
@timonegk timonegk deleted the feature/better_configuration branch January 1, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaagut jaagut jaagut left review comments

@timonegk timonegk timonegk approved these changes

Assignees

@lilioid lilioid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve application configuration
3 participants
@lilioid @timonegk @jaagut