add loaded signal to entity backend and delay entity override loading #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft PR to fix array contents not being deserialized during loading when an entity contains override values for an array property.
This PR adds a signal to PandoraEntityBackend to indicate when loading is completed. On PandoraEntity, loading of overrides is delayed until that signal is emitted. This is because the root cause of the issue is that when the overrides are loaded, the properties have not yet been fully loaded and thus it's not (currently) possible to check the type setting of the array.
There are some other ways this could be solved though:
This issue would also likely affect any future types that contain other types, such as Dictionary.
The unit test is currently still failing, though in practice the issue seems at least initially resolved, but there may be other affected cases yet.
Addressed issues
TODO