MISC: Add key binding feature #1830
Conversation
# Conflicts: # src/ScriptEditor/ui/ScriptEditorRoot.tsx # src/Settings/Settings.ts
| } | ||
| } | ||
| // Terminal-ClearScreen | ||
| if (isKeyCombinationPressed(newCombination, { control: true, code: KEYCODE.L })) { |
There was a problem hiding this comment.
We should probably make this one bindable, but that can be for another day.
| // Bash hotkeys | ||
| if ( | ||
| Settings.EnableBashHotkeys && | ||
| (isKeyCombinationPressed(newCombination, { control: true, code: KEYCODE.M }) || |
There was a problem hiding this comment.
The bash hotkeys definitely should be bindable, but that can also be for another day.
|
It's ready for the next review now. I moved |
|
This looks good to me. One last thing is, can you use the deploy action in GitHub to host this at https://catloversg.github.io/bitburner-src (or maybe it's already hosted somewhere else) so we can play with it? I'd like to, but more importantly Zoë expressed a strong desire to have a heads-up on keybinding-related changes, and they're the only person I am certain of who has a Mac to test this on. |
|
It's available at https://catloversg.github.io/bitburner-src/. |
|
There's one last thing I think we should add before we merge; the rest can be added iteratively later. That is Denis' suggestion of only saving explicitly set keybinds, so that future changes to the defaults won't end up locked in. This is a chunk of additional complexity (you'll probably need to keep a merged and unmerged version for different purposes), but it's something that lots of other games do and one that I think we will regret it we don't have. And it has to be done now, to be effective. Note that this pretty much requires that hitting "default" on the secondary bind restores the secondary default, since hitting "default" will be how you clear a "set" keybind. (Add opposed to "clear", which sets it to clear.) |
This feature has been requested for a long time. It's the only way to properly fix wrong behaviors of shortcuts.
Tested: I played for a while with US, US Intl, and US Dvorak.
Screenshots:
Closes #420.