BUGFIX: ns.corporation.bribe can bribe faction that player is not member of #1966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this bug when checking the UI of the bribing feature. We disable the "Bribe" button when the player is not a member of any valid factions, but with
ns.corporation.bribe
, they can bribe a valid faction even when they are not a member of that faction. This PR fixes it.Test save:
test bribe.gz
Test code:
Before:
After: