Examples: swap magic numbers for EXIT_ codes #1618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks good in principle. But your PR already needs to be rebased now. (Did you accidentally build on an outdated version of master?) |
real-or-random
added
user-documentation
real-or-random
changed the title
theStack
reviewed
Oct 15, 2024
Comment on lines
-73
to
+74
| return 0; | ||
| return EXIT_FAILURE; |
There was a problem hiding this comment.
note that the EXIT_... constants are only meant to be used for program termination (i.e. to be returned from main, or as argument to exit(...)), not as return codes in our own functions (in this case tweak(...))
high089123
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1609 this PR will use EXIT_{success, failure} codes instead of magic numbers in the return statements.
If it looks good I will continue to remove the asserts too in another commit.