Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update nLocktime nSequence handling #57

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: Update nLocktime nSequence handling #57

merged 1 commit into from
Dec 5, 2023

Conversation

sirdeggen
Copy link
Contributor

@sirdeggen sirdeggen commented Nov 29, 2023 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Issue Details

nLocktime handling should ignore 0, and only check nSequence of inputs in the case that nLocktime is non 0 to ensure the tx is indeed final.

@sirdeggen sirdeggen requested a review from a team as a code owner November 29, 2023 00:09
@arkadiuszos4chain arkadiuszos4chain self-requested a review November 29, 2023 08:58
@arkadiuszos4chain arkadiuszos4chain merged commit 92eff98 into main Dec 5, 2023
1 of 2 checks passed
@arkadiuszos4chain arkadiuszos4chain deleted the nlocktime-update branch December 5, 2023 13:13
@bsvassociation-bot bsvassociation-bot mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadiuszos4chain arkadiuszos4chain arkadiuszos4chain approved these changes

Assignees

@sirdeggen sirdeggen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirdeggen @arkadiuszos4chain