refactor(SPV-1095): apply pr comments suggestions

bitcoin-sv · Oct 7, 2024 · 9a42a63 · 9a42a63
1 parent 7c6e8b4
commit 9a42a63
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/examples/sync_merkleroots/sync_merkleroots.go b/examples/sync_merkleroots/sync_merkleroots.go
@@ -25,7 +25,7 @@ func (db *db) SaveMerkleRoots(syncedMerkleRoots []walletclient.MerkleRoot) error
 	return nil
 }
 
-func (db *db) GetLastEvaluatedKey() string {
+func (db *db) GetLastMerkleRoot() string {
 	if len(db.MerkleRoots) == 0 {
 		return ""
 	}

diff --git a/sync_merkleroots.go b/sync_merkleroots.go
@@ -37,8 +37,8 @@ type MerkleRoot struct {
 
 // MerkleRootsRepository is an interface responsible for saving synced merkleroots and getting last evaluat key from database
 type MerkleRootsRepository interface {
-	// GetLastEvaluatedKey should return the merkle root with the heighest height from your storage or undefined if empty
-	GetLastEvaluatedKey() string
+	// GetLastMerkleRoot should return the merkle root with the heighest height from your storage or undefined if empty
+	GetLastMerkleRoot() string
 	// SaveMerkleRoots should store newly synced merkle roots into your storage;
 	// NOTE: items are ordered with ascending order by block height
 	SaveMerkleRoots(syncedMerkleRoots []MerkleRoot) error
@@ -52,7 +52,7 @@ func (wc *WalletClient) SyncMerkleRoots(ctx context.Context, repo MerkleRootsRep
 		defer cancel()
 	}
 
-	lastEvaluatedKey := repo.GetLastEvaluatedKey()
+	lastEvaluatedKey := repo.GetLastMerkleRoot()
 	requestPath := "merkleroots"
 	lastEvaluatedKeyQuery := ""
 	previousLastEvaluatedKey := lastEvaluatedKey