feat(SPV-912): handle invalid configuration #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid previous behavior:
instance of WalletClient is created with empty authorizations fields
For example:
client := walletclient.NewWithXPriv("localhost:3003", "")
also when we use
client := walletclient.NewWithAccessKey("localhost:3003", "")
and
client := walletclient.NewWithAdminKey("localhost:3003", "")
and
client := walletclient.NewWithXPub("localhost:3003", "")
expected behavior: instance should not be created
The "constructor" functions now also return
error
:configurer
instances besides configuring a client, make validation and return err if necessary.Wrap
functionality.spv-wallet/models
dependency was updated, because without it, theerrors.Is
didn't work withSPVError
type.Pull Request Checklist