Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-1214): admin contact filter #308

Merged
merged 3 commits into from
Dec 19, 2024
Merged

feat(SPV-1214): admin contact filter #308

merged 3 commits into from
Dec 19, 2024

Conversation

jakubmkowalski
Copy link
Contributor

This pull request includes several updates and improvements to the spv-wallet-go-client package. The changes primarily involve updating dependencies and modifying a function to use a more specific filter type.

Dependency updates:

  • Updated github.com/bitcoin-sv/spv-wallet/models dependency from version v1.0.0-beta.37 to v1.0.0-beta.38 in both examples/go.mod and go.mod files. [1] [2]

Function modification:

  • Changed the AdminGetContacts function in http.go to use filter.AdminContactFilter instead of filter.ContactFilter for the conditions parameter, providing a more specific filter type for admin contact searches.

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@jakubmkowalski jakubmkowalski self-assigned this Dec 17, 2024
@jakubmkowalski jakubmkowalski requested a review from a team as a code owner December 17, 2024 16:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @ac4ch resulted in success.

@jakubmkowalski jakubmkowalski changed the title Feat/spv 1214 admin contact filter feat(SPV-1214): admin contact filter Dec 17, 2024
@ac4ch ac4ch added the tested PR was tested by a team member label Dec 19, 2024
@jakubmkowalski jakubmkowalski merged commit 0d28ad6 into main Dec 19, 2024
12 checks passed
@jakubmkowalski jakubmkowalski deleted the feat/SPV-1214-admin-contact-filter branch December 19, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-4chain chris-4chain chris-4chain approved these changes

@ac4ch ac4ch ac4ch approved these changes

Assignees

@jakubmkowalski jakubmkowalski

Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakubmkowalski @ac4ch @chris-4chain