Merge pull request #168 from bitcoin-sv/fix/off-by-one-error

[ FIX ] off by one sats check when adding an output.
bitcoin-sv · Dec 29, 2024 · d467141 · d467141
2 parents 8bfc6eb + bd8e49d
commit d467141
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bsv/sdk",
-  "version": "1.2.19",
+  "version": "1.2.20",
   "type": "module",
   "description": "BSV Blockchain Software Development Kit",
   "main": "dist/cjs/mod.js",

diff --git a/src/transaction/Transaction.ts b/src/transaction/Transaction.ts
@@ -439,7 +439,7 @@ export default class Transaction {
     this.cachedHash = undefined
     if (!output.change) {
       if (typeof output.satoshis === 'undefined') throw new Error('either satoshis must be defined or change must be set to true')
-      if (output.satoshis <= 0) throw new Error('satoshis must be a positive integer or zero')
+      if (output.satoshis < 0) throw new Error('satoshis must be a positive integer or zero')
     }
     if (!output.lockingScript) throw new Error('lockingScript must be defined')
     this.outputs.push(output)