Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The significant change is to the hash classes / functions in regard to the enc (encoding) input argument.
This started from an incorrect comment on PublicKey.verify that the default encoding was 'hex' when it is in fact 'utf8'.
Following this into the hash classes it turned out that the same enc input parameter was being used to determine both the encoding of the input message (msg) AND the desired output type (number[] vs hex string).
As this needed resolving in any case, and it looked like very few tests were passing 'hex' encoding. This PR proposes to resolve the issue by:
digestHex()
method to mirrordigest()
when a hex string output is desired.Two tests were updated. All tests pass.
This is a breaking change to fix a broken API situation.