feature: update bdk-cli to use bdk_wallet v1
#174
Draft
+1,875
−971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add bdk_wallet to Cargo.toml * the bdk crate is still in using because of the error enum, which will be removed after feedback [Ticket: X]
-update imports from bdk to use bdk_wallet - set `enable_rbf` command option to be `true` by default - add `parse_address` fn to parse address from string - replace `ExtendedPrivateKey` with `Xpriv` from bdk_wallet - update derving address from string to use `assumed_check` [Ticket: X]
- replace `list_transactions` method with `transactions` - format `recipients` to be a vec of `ScriptBuf` and `Amount` - update creating and serializing `Psbt`s - update `fee_rate` method and default to `FeeRate::BROADCAST_MIN` - replace `allow_shrinking` method with `drain_to` method - update `handle_offline_wallet_subcommands` to use `PersistedWallet<D>` instead of `Wallet<D>` [Ticket: X]
- update imports from bdk to bdk_wallet - fix compilation warnings [Ticket: X]
- add `parse_address` method - remove `key-value-db` feature as it uses `sled` - update `open_database` fn to return rusqlite::Connection - update `new_wallet` fn to return `PersistedWallet<Connection>` [Ticket: X]
- Replace `bdk` with `bdk_wallet` v1 in Cargo.toml - replace removed features in bdk features/mods with crates [Ticket: X]
-add error enum for handling errors [Ticket: X]
tvpeter
force-pushed
the
feat/bdk-wallet-v1-update
branch
from
6653428 to
c7bd335
Compare
- replace bdk::error with custom error enum - update imports and handling of errors [Ticket: X]
tvpeter
force-pushed
the
feat/bdk-wallet-v1-update
branch
from
c7bd335 to
50233dd
Compare
- update deps imports - refactor reserves feature [Ticket: X]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR update
bdk-clito usebdk_walletv1Issue: #172 (comment)
Notes to the reviewers
list_transactionswithtransactionsenable_rbfto betrueby defaultnew_walletto returnPersistedWallet<Connection>zeroizeto version1.8.1from<1.4.0bdk-reservesfrom0.27.1to0.29.0bdk/electrumwithbdk_electrumfor theelectrumfeaturebdk_esplorafor thebdk/use-esplora-ureqandbdk/use-esplora-reqwestfeaturesbdk_bitcoind_rpclib to replacebdk/rpcfeaturehwilibrary to replacebdk/hardware-signerfeatureChangelog notice
enable_rbfto betrueby defaultPartiallySignedTransactiontoPsbtzeroizeto version1.8.1from<1.4.0bdk-reservesfrom0.27.1to0.29.0bdk/electrumwithbdk_electrumfor theelectrumfeaturebdk/use-esplora-ureqandbdk/use-esplora-reqwestwithbdk_esploralibbdk/rpcwithbdk_bitcoind_rpclibbdk/hardware-signerwithhwilibChecklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: