feat: expose ElectrumClient::block_headers_subscribe method #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a cheat: the method is not intended for a 1-time use, but rather is meant to open a subscription. In any case the Electrum client does return what I think our user wants (LDK-node please confirm!).
I'm not ready to merge this one just yet because I actually didn't expose the
Header
type fully (which would require 4 new types:Version
,BlockHash
,TxMerkleNode
, andCompactTarget
). If we do want to expose theblock_header()
method, then it might actually be worth taking the time exposing the wholeHeader
type from rust-bitcoin.Let me know if you have an opinion either way, because this would be a breaking change if we expose a simplified version and eventually want to return the full Header.
Changelog