Use new account 1 wallet for tests #692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
test/new-wallets
branch
from
b5a0572 to
8d0c94d
Compare
thunderbiscuit
force-pushed
the
test/new-wallets
branch
from
8d0c94d to
c816705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our wallet was over 500 indices deep, which made tests slower to complete.
Note that the descriptors associated with the persistence tests are not changed, as they would require creating and committing new sqlite files but the old ones are fine and the tests are not live anyway so don't require any sync.
Ok this is turning into a bundle of tiny fixes we just need and I don't feel like PRing individually.