Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make update drop-able #95

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

rustaceanrob
Copy link
Collaborator

On further inspect of the update method, I do not think it was quite cancel-safe yet. The contract of select! is that either arm of the macro might be dropped. When Drop is called on the update method, we have the locally scoped variable chain_changeset that would be dropped. Here I move that into the struct so Drop may be called on the update future without loss of data.

@rustaceanrob rustaceanrob merged commit 3a51016 into bitcoindevkit:master Jan 21, 2025
2 checks passed
@rustaceanrob rustaceanrob deleted the cancel-1-20 branch January 21, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant