For wallet change sets persist and verify descriptor hashes #1234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #1101, this is an alternative solution to #1203
The idea is rather than making changes in the chain module to handle persisting and verifying descriptor hash values at the wallet level. Any non-wallet chain module users can reference how we do it for wallet or can develop custom solutions.
Notes to the reviewers
I also cleaned up some related wallet module errors.
And I fixed some new clippy errors by replacing
.or_insert_with(Default::default)
with.or_default()
.Changelog notice
Added
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features: