Introduce missing-at/last-missing timestamps
#1811
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may, if we introduce new fields to `TxUdpate`, they can be minor non-breaking updates.
evanlinjin
force-pushed
the
missing_marker
branch
from
287b146 to
fe09eab
Compare
evanlinjin
changed the title
MissingMarkermissing-at/last-missing timestamps
LagginTimes
force-pushed
the
missing_marker
branch
from
7f09b70 to
49a64ba
Compare
This is a set of txids missing from the mempool.
The missing-at and last-missing timestamp informs the `TxGraph` when the transaction was last deemed as missing from the mempool (evicted). The canonicalization algorithm is changed to disregard transactions with a last-missing timestamp greater or equal to it's last-seen timestamp. The exception is when we have a canonical descendant due to rules of transitivity.
This is for conveniently adding associations of txid <-> spk. We expect that these txids exist in the spk history. Otherwise, it means the tx is evicted from the mempool and we need to update the `missing_at` value in the sync response.
This is a convenience method for adding unconfirmed txs alongside their associated spks the the sync request. This way, we will be able to detect evictions of these transactions from the mempool.
LagginTimes
force-pushed
the
missing_marker
branch
from
0f52ead to
2e31bc7
Compare
|
Looks like only breaking changes are on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1740.
Description
This PR replaces #1765. For context and the original discussion that led to this change, please refer to this comment.
This PR addresses a potential malicious double-spending issue by introducing improvements to unconfirmed transaction tracking. Key changes include the addition of
TxUpdate::missingthat tracks transactions that have been replaced and are no longer in the mempool, and the inclusion oflast_missingandmissing_attimestamps inTxGraphto track when a transaction was last deemed missing.SpkWithHistoryis introduced inSpkClientto track expectedTxids for eachspk. During a sync, if anyTxids fromSpkWithHistoryare not in the current history of anspkobtained from the chain source, thoseTxids are considered missing. Support forSpkWithHistoryhas been added to bothbdk_electrumandbdk_esplorachain source crates.The canonicalization algorithm is updated to disregard transactions with a
last_missingtimestamp greater than or equal to theirlast_seentimestamp, except in cases where transitivity rules apply.Changelog notice
TxUpdate::missingtracks transactions that have been replaced and are no longer present in mempool.last_missingandmissing_attimestamps inTxGraphtrack when a transaction was last marked as missing from the mempool.last_missingtimestamp greater than or equal to it'slast_seentimestamp, except when a canonical descendant exists due to rules of transitivity.SpkWithHistoryinSpkClientkeeps track of expectedTxids for eachspk.SpkWithHistorysupport added forbdk_electrumandbdk_esplora.SyncRequestBuilder::expected_txsadds an association betweenTxidandspk.SyncRequestExt::check_unconfirmed_statusesadds unconfirmed transactions alongside theirspks during sync.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: