Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix varint comment for DrainWeights #25

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

jp1ac4
Copy link
Contributor

@jp1ac4 jp1ac4 commented Apr 4, 2024

Following #21, the output_weight in DrainWeights must not take into account a change in varint output count as this is now handled elsewhere.

The change in varint output count is now handled elsewhere.
Copy link
Collaborator

@LLFourn LLFourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh nice catch.

@LLFourn LLFourn merged commit 434c6e8 into bitcoindevkit:master Apr 5, 2024
5 checks passed
@jp1ac4 jp1ac4 deleted the update-drainweights-docs branch June 21, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants