-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support taproot for signAllInputsHD #2137
base: master
Are you sure you want to change the base?
Conversation
jasonandjay
commented
Jul 24, 2024
- issue discussion: Feature Request: Taproot support for signAllInputsHD #2132
- feat
- affected Signature Methods
- signAllInputsHD
- signAllInputsAsyncHD
- signInputHD
- signInputAsyncHD
- remove conflict default sighashTypes of signInputHD
- Transaction.SIGHASH_DEFAULT for _signTaprootInput
- Transaction.SIGHASH_ALL for _signInput
- so we should remove the outermost default signType
- add integration test for HDWallet with tapBip32Derivation
- we will need more integration tests later.
- affected Signature Methods
This comment was marked as resolved.
This comment was marked as resolved.
How about code review progress? |
@junderw Could you check this PR? |
I have an observation regarding the asymmetry in I'm not saying this is incorrect, but this PR allows On the other hand, in As a result, it's not possible to use Again, I'm not saying this is necessarily wrong. Perhaps this is the only viable approach, but I wanted to highlight this to see if there’s anything further we can do, or at least reflect this behavior more clearly in the comments at the top of |