Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters: add 241 (2023-03-08) #1036

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

harding
Copy link
Collaborator

@harding harding commented Mar 2, 2023

Also adds a blog post announcing the podcast.

  • Lede, alt-vault proposal, releases/RCs, topic links
  • Bitcoin Core PR Review Club summary @LarryRuane
  • LND 7462 @adamjonas

@harding harding changed the title Newsletters: add 241 (2023 Newsletters: add 241 (2023-03-08) Mar 2, 2023
_posts/en/2023-03-08-podcast.md Outdated Show resolved Hide resolved
_posts/en/2023-03-08-podcast.md Show resolved Hide resolved
Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments

_posts/en/2023-03-08-podcast.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
_posts/en/2023-03-08-podcast.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
@bitschmidty
Copy link
Contributor

This piece of news was passed to me for consideration in the newsletter. Im not sure we cover roadmaps on their own, but I suppose if there is a related LND/bolt12 update it could be worked in.

@LarryRuane
Copy link
Collaborator

Added review club summary 8122c2f

Comment on lines 108 to 112
is a PR by Anthony Towns that improves activation and deactivation
logic for the [Bitcoin Inquisition][] project, which runs on [signet][topic signet].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quite strongly think "improves" is not the right word here. It swaps it out for a different mechanism; they are used in different contexts with very different goals. I don't think there is any notion of one being better than the other.

Suggested change
is a PR by Anthony Towns that improves activation and deactivation
logic for the [Bitcoin Inquisition][] project, which runs on [signet][topic signet].
is a PR by Anthony Towns that adds a new method for activating and deactivating
soft forks in the [Bitcoin Inquisition][] project, designed to be run on [signet][topic signet]
and used for testing.

Comment on lines 112 to 113
While most of the [Bitcoin Inquisition PRs][bi prs] implement specific consensus or
relay policy changes, this PR modifies the Bitcoin Inquisition framework itself.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
While most of the [Bitcoin Inquisition PRs][bi prs] implement specific consensus or
relay policy changes, this PR modifies the Bitcoin Inquisition framework itself.

It's unclear what "the Bitcoin Inquisition framework" would mean.

Comment on lines 121 to 122
Specifically, this PR replaces [BIP9][] block version bit semantics with what
are called [Heretical Deployments][].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the paragraph would flow better if this was the first sentence, rather than the last sentence.

Comment on lines 133 to 136
The threshold of merging consensus changes to a signet-only repository
is much lower than merging to Core.
Merging changes to Core that aren't yet activated introduces the
risk that bugs can leak in a way that affects existing behavior."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The threshold of merging consensus changes to a signet-only repository
is much lower than merging to Core.
Merging changes to Core that aren't yet activated introduces the
risk that bugs can leak in a way that affects existing behavior."
Merging consensus changes to a separate repository is much less risky than merging to Core;
adding soft fork logic, even if not activated, may introduce bugs that affect existing behavior."

machine period (this period is fixed for Heretical Deployment)."
a2link="https://bitcoincore.reviews/bitcoin-inquisition-16#l-126"

q3="Why is Taproot buried in signet?"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
q3="Why is Taproot buried in signet?"
q3="Why is Taproot buried in this PR?"

@LarryRuane LarryRuane force-pushed the 2023-03-08-newsletter branch from 2d99feb to 2663704 Compare March 7, 2023 13:33
@LarryRuane
Copy link
Collaborator

Force pushed to address @glozow's suggestions -- thanks!

@LarryRuane LarryRuane force-pushed the 2023-03-08-newsletter branch 2 times, most recently from 89e4349 to 70e84a5 Compare March 7, 2023 13:49
Copy link
Collaborator

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really liked the write-up of Greg’s idea. Curious on your thoughts regarding terminology.

_posts/en/2023-03-08-podcast.md Outdated Show resolved Hide resolved
_posts/en/2023-03-08-podcast.md Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
_posts/en/newsletters/2023-03-08-newsletter.md Outdated Show resolved Hide resolved
@harding
Copy link
Collaborator Author

harding commented Mar 7, 2023

Pushed edits for all reviewer feedback, thanks @paulkania @xekyo @bitschmidty @glozow ! Added lede, updated releases/RCs, and added topic links. Reviewed contributions by @LarryRuane and @adamjonas (thanks!). Thanks everyone!

@bitschmidty bitschmidty force-pushed the 2023-03-08-newsletter branch from cdcb166 to a8242bd Compare March 8, 2023 11:31
Copy link
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed releases section, topic links, PR Review Club (2 small changes made), and ensured all review comments were resolved.

Squashed commits.

@bitschmidty bitschmidty merged commit cdf7018 into bitcoinops:master Mar 8, 2023
@bitschmidty
Copy link
Contributor

Thank you @harding for authoring the newsletter (and blog post announcement!) with @adamjonas @LarryRuane! And thanks to @glozow @paulkania @xekyo for the reviews 🚀


One of the advantages to users of this approach over the original
`OP_VAULT` design is that the freeze leafscript can contain any
authorization conditions Alice wants to specify. In the `OP_VAULT`
Copy link
Contributor

@jamesob jamesob Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, this was the case with BIP 345 before Sanders made these suggestions. Search for optional auth. scriptPubKey in the current text of the BIP. Greg's rework doesn't add this in.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was that the result of some previous change in the design? In our original coverage of the idea, we linked to a post by AJ where he mentioned that as a concern, see https://bitcoinops.org/en/newsletters/2023/01/18/#proposal-for-new-vault-specific-opcodes where we wrote,

Towns notes that [...] any third party who learns the address can also freeze the user’s funds (although they’ll have to pay a transaction fee to do so), creating an inconvenience for the user.

If it was a previous change to the proposal that added the ability to allow requiring arbitrary authorization for freezing, then I think we're technically correct to say the an advantage of Greg's approach over the original approach (as posted to the ML on Jan 9th) is this ability.

However, I also get that it's misleading in the sense that it's not an advantage over what you wanted to ship at the time Greg suggested it. Would you like us to print a correction in next week's newsletter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants