-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds simple localization features #247
Conversation
ACK 009fd1f. This seems fine for a low-key rollout of localized newsletters. If we continue to get japanese and other language translations, we could:
Thanks for doing this @bitschmidty ! And thanks for handling everything with CG. |
009fd1f
to
29ee426
Compare
Rebased and pushed a commit which filters out non english posts from the existing feed.xml We should also consider adding language specific feeds in the future. |
Created #251 to track non blocking suggestions to localization in the future |
Did you copy the base
|
29ee426
to
560573f
Compare
Split commits for the feed into two:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK. One bug (need to also filter /en/publications
) and one style suggestion. Thanks, @bitschmidty!
Tested by builiding site with and without this PR as is, then diffing static HTML. Then doing that again with the suggested translation on top of this PR. Also browsed a local preview of the test site with the suggested translation. Reviewed code.
ACK 560573f. Thanks for splitting out the feed change into two commits. I've tested the following:
Once you've addressed @harding's feedback, this is ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK ba22ddd Thanks!
ACK ba22ddd |
ba22ddd
to
f0b0377
Compare
I've squashed the two fixup commits into the relevant commits. Merging now. Thanks for delivering this, @bitschmidty ! |
Changes:
Notes:
Testing: