Add BitcrowdEcto.Changeset.auto_cast/3

[maltoe]

This patch consolidates some versions of automatic casting we had flying around. This version features casting scalars & embeds as well as required validations based on :required or :optional options.

Additionally, this adds BitcrowdEcto.Assertions.assert_cast_error_on/2.

[ammancilla]

Nice function. I can imagine a couple of use cases for this but what's the use case you had in mind?

Left a blocker. More than requesting changes is an question.

[maltoe]

Nice function. I can imagine a couple of use cases for this but what's the use case you had in mind?

Use-case is documented here https://bitcrowd.atlassian.net/browse/SIS-4357, but the code originated in another project and has existed in some variant in all our PDF/mail apps for ages.

[ammancilla]

Nice function. I can imagine a couple of use cases for this but what's the use case you had in mind?

Use-case is documented here https://bitcrowd.atlassian.net/browse/SIS-4357, but the code originated in another project and has existed in some variant in all our PDF/mail apps for ages.

I see, thanks for the reference. I am not a big fan of the auto_ prefix in the function since I don't see the "auto" in the implementation itself, it is just plain casting (less powerful than the Ecto.Changeset one but still). I would vote for removing the auto_ (not a strong opinion)

[maltoe]

Nice function. I can imagine a couple of use cases for this but what's the use case you had in mind?

Use-case is documented here https://bitcrowd.atlassian.net/browse/SIS-4357, but the code originated in another project and has existed in some variant in all our PDF/mail apps for ages.

I see, thanks for the reference. I am not a big fan of the auto_ prefix in the function since I don't see the "auto" in the implementation itself, it is just plain casting (less powerful than the Ecto.Changeset one but still). I would vote for removing the auto_ (not a strong opinion)

Open for other names, but just cast conflicts with Ecto.Changeset and client modules are likely to import both (in fact, BitcrowdEcto.Schema users do that automatically).

I thought auto_ because it's automatically figuring out the fields. How about inflect_cast?

[ammancilla]

Nice function. I can imagine a couple of use cases for this but what's the use case you had in mind?

Use-case is documented here https://bitcrowd.atlassian.net/browse/SIS-4357, but the code originated in another project and has existed in some variant in all our PDF/mail apps for ages.

I see, thanks for the reference. I am not a big fan of the auto_ prefix in the function since I don't see the "auto" in the implementation itself, it is just plain casting (less powerful than the Ecto.Changeset one but still). I would vote for removing the auto_ (not a strong opinion)

Open for other names, but just cast conflicts with Ecto.Changeset and client modules are likely to import both (in fact, BitcrowdEcto.Schema users do that automatically).

I thought auto_ because it's automatically figuring out the fields. How about inflect_cast?

Sounds good, either that or apply_cast as well.

[maltoe]

renamed to cast_all @ammancilla