Skip to content

Commit

Permalink
Review feedbacks, changelog texts
Browse files Browse the repository at this point in the history
  • Loading branch information
bluemoonecho committed Jan 17, 2024
1 parent d1f3ef3 commit 1f10725
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@

### Added

- Page Header Organism, added a page header organism component and storybook docs for it.
- New Pageheader Organism-level component, that encapsulates what was previously an example component built using utility classes.

- Sidebar component updates
- Updates the layout of the Sidebar Organism-level component, improvements to the scrolling behavior and uses the invisible button variant.

- Badge with Label, added an example showing a text label rendered next to a badge component, to the badge docs.
- A new layout component at `atoms/switcher`, that lays out its children in a horizontal row with consistent spacing between children. The layout switches to a vertical stack once the width of the component passes below a threshold, or the number of children goes over a limit.
Expand Down
11 changes: 6 additions & 5 deletions scss/bitstyles/organisms/page-header/PageHeader.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,14 @@ breadCrumbsMenu.innerHTML = `
</svg>
</li>`;

export const header = document.createElement('div');
export const header = document.createElement('header');
header.innerHTML = `
<div class="u-flex u-justify-between u-flex-wrap u-items-center u-margin-m-y">
<div class="u-flex u-flex-wrap u-items-center">
<h1 class="u-margin-m-right u-break-text">Title Header</h1>
<div class="u-flex-shrink-0 u-margin-m-bottom@s">
<span class="a-badge u-font-medium" data-theme="brand-1">Online</span>
<div class="u-flex u-flex-wrap u-items-center">
<h1 class="u-margin-m-right u-break-text">Title Header</h1>
<div class="u-flex-shrink-0 u-margin-m-bottom@s">
<span class="a-badge u-font-medium" data-theme="brand-1">Online</span>
</div>
</div>
</div>`;

Expand Down

0 comments on commit 1f10725

Please sign in to comment.