Render story iframe in external document #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/generate_version_showcase.ex
Outdated
| full_file_path = Path.join(full_dir_path, file_name) | ||
| iframe_src = "/#{relative_dir_path}/#{file_name}" | ||
|
|
||
| iframe_srcdoc = ~s(<html lang="en"><head><title>#{iframe_src}</title><style>#{style}</style><link rel="stylesheet" href="#{dist}/build/bitstyles.css"></head><body>#{Enum.join([extra_html, result]) |> String.replace("\n", "")}</body></html>) |
There was a problem hiding this comment.
Why does this even care about newlines 🤔 I guess this can be removed when it is not in an iframe anymore.
andreasknoepfle
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renders story iframes in external documents (
src="/file_path.html") instead of inlined documents(srcdoc="<html>..."). This is necessary for me to be able to use the WAVE browser extension to do accessibility checks of the components.WAVE cannot run checks on iframe on a page, so I need to "open iframe in a new tab" to run WAVE on its content. But you can only do that when the iframe is an external document.
Screen.Recording.2024-07-03.at.13.25.27.mov