Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phoenix_html v4 compatibility #130

Merged
merged 19 commits into from
Jul 18, 2024
Merged

phoenix_html v4 compatibility #130

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f78b906
Don't depend on Phoenix.HTML.Tag.content_tag in Showcase
angelikatyborska Jul 16, 2024
f6062c6
Don't depend on Phoenix.HTML.Tag.content_tag in Heading
angelikatyborska Jul 16, 2024
5cb5deb
Copy-paste "humanize" for default labels
angelikatyborska Jul 16, 2024
7918745
Run tests with unlocked deps on CI
angelikatyborska Jul 16, 2024
604f631
Don't depend on Phoenix.HTML.Form.label
angelikatyborska Jul 16, 2024
6b8c535
Don't depend on Phoenix.HTML.Form.input
angelikatyborska Jul 17, 2024
3dc2cbb
Don't depend on Phoenix.HTML.Form.select
angelikatyborska Jul 17, 2024
7ee8b51
Don't depend on Phoenix.HTML.Form.textarea
angelikatyborska Jul 17, 2024
f884ff9
Fix credo warnings
angelikatyborska Jul 17, 2024
ff6b719
Improve documentation
angelikatyborska Jul 17, 2024
f84a456
Define phoenix_html dependency
angelikatyborska Jul 17, 2024
9361e32
Ensure Phoenix.Component.to_form is available
angelikatyborska Jul 17, 2024
31522c6
Documentation fixes
angelikatyborska Jul 17, 2024
c1f5c61
Add changelog entry
angelikatyborska Jul 17, 2024
2cdd156
Copy over default values from core components
angelikatyborska Jul 17, 2024
aadd1c2
Remove private render_input func
angelikatyborska Jul 18, 2024
9f92878
Use sigil_H instead of copy of content_tag
angelikatyborska Jul 18, 2024
5b61a76
Rename label and input to avoid name clashes
angelikatyborska Jul 18, 2024
ca1ec04
Update changelog
angelikatyborska Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,20 @@ jobs:
- run: mix docs
- name: Check if versions showcase mix script finishes
run: mix run scripts/generate_version_showcase.ex

test-unlocked-deps:
runs-on: ubuntu-latest
name: unit (unlocked deps)
steps:
- uses: actions/checkout@v2
- uses: erlef/setup-beam@v1
with:
otp-version: '25.1'
elixir-version: '1.14.5'
- run: mix deps.unlock --all
- run: mix deps.get
- run: mix test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test


demo:
runs-on: ubuntu-latest
name: demo
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased

- Added support for phoenix_html `v4`. You can also continue using phoenix_html `v3`.
Copy link
Member

@andreasknoepfle andreasknoepfle Jul 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also document the newly added components for raw inputs and labels (whatever name you choose)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this enough ca1ec04 (#130) ? I was struggling to find the right words to describe the components in the changelog and gave up on writing more, hoping people would just look for more details in the components' documentation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

- Added support for bitstyles `v5.0.0`. You can continue using bitstyles_phoenix with a lower bitstyles version, or migrate your codebase to bitstyles `v5.0.0`.

### How to migrate to bitstyles `v5.0.0`
Expand Down
2 changes: 1 addition & 1 deletion lib/bitstyles_phoenix.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ defmodule BitstylesPhoenix do

### Translating error messages

Generated phoenix apps usally come with a helper for [translating error messages](https://github.com/phoenixframework/phoenix/blob/496123b66c03c9764be623d2c32b4af611837eb0/installer/templates/phx_web/views/error_helpers.ex#L23-L46)
Generated phoenix apps usually come with a helper for [translating error messages](https://github.com/phoenixframework/phoenix/blob/496123b66c03c9764be623d2c32b4af611837eb0/installer/templates/phx_web/views/error_helpers.ex#L23-L46)
using `gettext`. This helper can be used to translate error messages rendered with `bitstyles_phoenix`.

In order to do so you can configure the generated helper or write your own with the MFA configuration.
Expand Down
Loading
Loading