Skip to content

Update target frameworks #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Joy-less
Copy link
Contributor

This pull request removes unsupported target frameworks (.NET Core, .NET 6.0) and simplifies conditional compilation so it supports NETSTANDARD (.NET Standard 2.0) and NET (.NET 8.0 and .NET 9.0).

@bitfaster
Copy link
Owner

Wow, thanks!

I had started to look at this here #638, and planned to go back and effectively make your PR (so I would go in stages update fwks changes, then take each feature as a follow PR).

I think the gates will fail on your change, I just started a run - my other PR has fixes for that stuff in the build yaml files.

I will take a proper look at this on the weekend.

@Joy-less Joy-less mentioned this pull request Feb 6, 2025
@bitfaster
Copy link
Owner

I updated the build scripts so that your changes can compile: #670.

@Joy-less
Copy link
Contributor Author

I updated the build scripts so that your changes can compile: #670.

I merged the changes.

@bitfaster
Copy link
Owner

Build is failing because deleting framework packages is not backwards compatible (i.e. a breaking change), so this would have to be a major release:

Error: C:\Program Files\dotnet\sdk\9.0.200\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error CP0002: Member 'System.Threading.Tasks.ValueTask<V> BitFaster.Caching.IAsyncCache<K, V>.GetOrAddAsync<TArg>(K, System.Func<K, TArg, System.Threading.Tasks.Task<V>>, TArg)' exists on [Baseline] lib/net6.0/BitFaster.Caching.dll but not on lib/netstandard2.0/BitFaster.Caching.dll [D:\a\BitFaster.Caching\BitFaster.Caching\BitFaster.Caching\BitFaster.Caching.csproj]

@Joy-less
Copy link
Contributor Author

Joy-less commented Mar 4, 2025

Build is failing because deleting framework packages is not backwards compatible (i.e. a breaking change), so this would have to be a major release

Is there going to be a major release soon? What's the plan?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants