Fix audit changes (#247)

pallets/carbon-credits/src/functions.rs

@@ -223,7 +223,7 @@ impl<T: Config> Pallet<T> {
 			let project = project.as_mut().ok_or(Error::<T>::ProjectNotFound)?;
 
 			// approved projects cannot be modified
-			ensure!(!project.approved.is_approved(), Error::<T>::CannotModifyApprovedProject);
+			ensure!(project.approved.is_rejected(), Error::<T>::CannotModifyApprovedProject);
 
 			// only originator can resubmit
 			ensure!(project.originator == admin, Error::<T>::NotAuthorised);

pallets/carbon-credits/src/types.rs

@@ -183,4 +183,16 @@ impl ProjectApprovalStatus {
 			Rejected => false,
 		}
 	}
+
+	/// Check if the project is rejected.
+	///
+	/// Returns `true` if the project is rejected, `false` otherwise.
+	pub fn is_rejected(self) -> bool {
+		use ProjectApprovalStatus::*;
+		match self {
+			Approved => false,
+			Pending => false,
+			Rejected => true,
+		}
+	}
 }

pallets/dex/src/lib.rs

@@ -355,8 +355,6 @@ pub mod pallet {
 		NoReceivables,
 		/// receivable amount is less than payment
 		ReceivableLessThanPayment,
-		/// Payments list is full
-		PaymentsListFull,
 		/// User has too many open orders
 		OpenOrderLimitExceeded,
 		/// User has too many units as unpaid open orders