Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flutter like background playback example #72

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

stonko1994
Copy link
Contributor

Description

Changes

In #71 we introduced support for background playback on iOS. We did that by explicitly calling AVAudioSession inside of the AppDelegate.swift. However, this was not really flutter like.

This PR adds a new sample showcasing how this can be achieved per page from flutter without the need of touching the AppDelegate.swift

Comment on lines +9 to +11
/// This example showcases how to achieve background playback with the
/// Bitmovin Player using the `audio_session` package.
/// https://pub.dev/packages/audio_session
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have comments on other samples but I thought it would make sense to add it.

@@ -72,6 +75,15 @@ class Home extends StatelessWidget {
},
child: const Text('Casting'),
),
Visibility(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would make sense to hide this example on Android for now since it's not yet supported there.

@stonko1994 stonko1994 requested a review from hawk23 November 17, 2023 14:16
Copy link
Collaborator

@hawk23 hawk23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💪 Manual testing looking good as well

@stonko1994 stonko1994 merged commit 7ed6c3d into main Nov 20, 2023
@stonko1994 stonko1994 deleted the feature/add-background-playback-example branch November 20, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants