Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/redis] fix: update JSON schema to allow string values for values passed to tpl #30526

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[bitnami/redis] fix: update JSON schema to allow string values for values passed to tpl #30526

wants to merge 5 commits into from

Conversation

piccit
Copy link

@piccit piccit commented Nov 19, 2024 •
edited
Loading

Description of the change

Updates all properties in values.schema.json that are directly passed to tpl to also allow for string fields.

Benefits

Fixes schema to allow passing strings to tpl for all values that are template-able

Possible drawbacks

None

Applicable issues

Additional information

None

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@piccit
[bitnami/redis] fix: update JSON schema to allow string values for va…
a167655 
…lues passed to tpl

Signed-off-by: Thomas Piccioli <[email protected]>
@piccit
bump chart version
ed86db4 
Signed-off-by: Thomas Piccioli <[email protected]>
@github-actions github-actions bot added redis triage Triage is needed labels Nov 19, 2024
@piccit piccit mentioned this pull request Nov 19, 2024
Closed
bitnami-bot and others added 3 commits November 19, 2024 14:11
@bitnami-bot
Update CHANGELOG.md
a6e2ba5 
Signed-off-by: Bitnami Containers <[email protected]>
@piccit
update commonLabels and labels
f40df12 
Signed-off-by: Thomas Piccioli <[email protected]>
@piccit
Merge branch 'fix-redisSchema' of https://github.com/piccit/bitnami-c…
005f913 
…harts into fix-redisSchema

Signed-off-by: Thomas Piccioli <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Nov 19, 2024
@github-actions github-actions bot removed the triage Triage is needed label Nov 19, 2024
@github-actions github-actions bot removed the request for review from carrodher November 19, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotamartos jotamartos Awaiting requested review from jotamartos

At least 1 approving review is required to merge this pull request.

Assignees

@jotamartos jotamartos

Labels
in-progress redis verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/redis] json schema too strict for any template-able value
4 participants
@piccit @jotamartos @carrodher @bitnami-bot