Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITAU-216] Change Move to Copy in Long Press Menu #197

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

brant-livefront
Copy link
Collaborator

🎟️ Tracking

BITAU-216

📔 Objective

Minor copy change: "Move to Bitwarden" is changed to "Copy to Bitwarden" in the long press menu. The functionality is currently more of a copy than a move (i.e. the local code isn't deleted automatically) so Emily/Matt wanted to reflect that a little better in our menu.

📸 Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-11-21 at 16 35 07

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Logo
Checkmarx One – Scan Summary & Detailsa553c7ad-b436-4339-8814-fad348b8f3eb

No New Or Fixed Issues Found

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.79%. Comparing base (d0a2899) to head (e317730).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ared/UI/Vault/ItemList/ItemList/ItemListView.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   67.79%   67.79%           
=======================================
  Files         214      214           
  Lines        9623     9623           
=======================================
  Hits         6524     6524           
  Misses       3099     3099           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brant-livefront brant-livefront merged commit 3c03964 into main Nov 26, 2024
9 checks passed
@brant-livefront brant-livefront deleted the brant/change-move-to-copy branch November 26, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants