Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-3028] [Defect] Password Manager seats count is blank after organization is created #10902

Conversation

cyprain-okeke
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-3028

📔 Objective

Password Manager seats count and seat limit is blank after organization is created and when updating the seat count or setting the seat limit

📸 Screenshots

Screen.Recording.2024-09-05.at.15.25.15.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke added the needs-qa Marks a PR as requiring QA approval label Sep 5, 2024
@cyprain-okeke cyprain-okeke requested a review from a team as a code owner September 5, 2024 14:30
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 33.10%. Comparing base (32903a2) to head (86e9bc5).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ing/organizations/adjust-subscription.component.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10902      +/-   ##
==========================================
- Coverage   33.11%   33.10%   -0.02%     
==========================================
  Files        2678     2678              
  Lines       83197    83201       +4     
  Branches    15822    15821       -1     
==========================================
- Hits        27553    27546       -7     
- Misses      53467    53478      +11     
  Partials     2177     2177              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Logo
Checkmarx One – Scan Summary & Details1bdf40c8-8766-4c1d-a75c-e8e7ed73d454

No New Or Fixed Issues Found

@github-actions github-actions bot temporarily deployed to Web Vault - EU QA Cloud September 5, 2024 18:26 Inactive
@cyprain-okeke cyprain-okeke removed the needs-qa Marks a PR as requiring QA approval label Sep 5, 2024
@cyprain-okeke cyprain-okeke merged commit 397141b into main Sep 5, 2024
35 of 36 checks passed
@cyprain-okeke cyprain-okeke deleted the ac-3028-defect-password-manager-seats-count-is-blank-after-organization-is-created branch September 5, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants