-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11882] Handled identity item and unsupported items during ProtonPass import. #10967
[PM-11882] Handled identity item and unsupported items during ProtonPass import. #10967
Conversation
Thank you for your contribution! We've added this to our internal Community PR board for review. |
libs/importer/src/importers/protonpass/protonpass-json-importer.ts
Outdated
Show resolved
Hide resolved
libs/importer/src/importers/protonpass/protonpass-json-importer.ts
Outdated
Show resolved
Hide resolved
libs/importer/src/importers/protonpass/protonpass-json-importer.ts
Outdated
Show resolved
Hide resolved
libs/importer/src/importers/protonpass/protonpass-json-importer.ts
Outdated
Show resolved
Hide resolved
Note that the linked issue mentions:
Unless I'm mistaken, I don't believe this PR introduces a way to track and report the items that were skipped. ![]() Not sure if this is essential though. I believe that introducing it would require changing the whole importer chain and it will affect other providers. @djsmith85 do you have thoughts? Other than that, I tested the changes in the Web Vault and it seems to work correctly 👍🏻 |
Thank you @aliaftab612! I'll wait to clarify a few things with @djsmith85 before proceeding further with this PR 🙂 |
libs/importer/src/importers/protonpass/protonpass-json-importer.ts
Outdated
Show resolved
Hide resolved
@Tyrrrz Yes, it does not address showing the skipped items, but I also agree with this being out of scope for this PR. @aliaftab612 Nice work and thank you for your contribution! |
Moving the PR to QA ✅ |
QA passed, merged. Thank you @aliaftab612! |
🎟️ Tracking
#10654
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes