Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10378] Unassigned Items Readonly After Edit Bug Fix #11340

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Sep 30, 2024

🎟️ Tracking

PM-10378

📔 Objective

update createWithServer and updateWithServer to return early on an orgAdmin edit

📸 Screen Recording

PM-10378-edit-unassigned.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Jingo88 Jingo88 requested a review from a team as a code owner September 30, 2024 18:01
Copy link
Contributor

github-actions bot commented Sep 30, 2024

Logo
Checkmarx One – Scan Summary & Details82ad5d66-f747-4e20-bf53-b0101ad3a9f0

No New Or Fixed Issues Found

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.23%. Comparing base (68f4c2e) to head (d807209).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11340      +/-   ##
==========================================
+ Coverage   33.22%   33.23%   +0.01%     
==========================================
  Files        2740     2740              
  Lines       85790    85794       +4     
  Branches    16365    16365              
==========================================
+ Hits        28506    28517      +11     
+ Misses      55023    55016       -7     
  Partials     2261     2261              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shane-melton shane-melton added the needs-qa Marks a PR as requiring QA approval label Sep 30, 2024
@Jingo88 Jingo88 removed the needs-qa Marks a PR as requiring QA approval label Oct 7, 2024
@Jingo88 Jingo88 merged commit 7098a24 into main Oct 7, 2024
66 of 67 checks passed
@Jingo88 Jingo88 deleted the PM-10378-unassigned-edit-readonly branch October 7, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants