Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13876] replace angular validation with html constraints validation #11816

Merged
merged 19 commits into from
Nov 6, 2024

add constraints that assign email address defaults

c356c7a
Select commit
Loading
Failed to load commit list.
Merged

[PM-13876] replace angular validation with html constraints validation #11816

add constraints that assign email address defaults
c356c7a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 1, 2024 in 0s

33.51% (-0.02%) compared to bb79fdb

View this Pull Request on Codecov

33.51% (-0.02%) compared to bb79fdb

Details

Codecov Report

Attention: Patch coverage is 30.35714% with 39 lines in your changes missing coverage. Please review.

Project coverage is 33.51%. Comparing base (bb79fdb) to head (c356c7a).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...enerator/core/src/policies/catchall-constraints.ts 12.50% 14 Missing ⚠️
...erator/core/src/policies/subaddress-constraints.ts 8.33% 11 Missing ⚠️
libs/tools/generator/core/src/data/generators.ts 37.50% 10 Missing ⚠️
libs/common/src/tools/state/user-state-subject.ts 33.33% 0 Missing and 2 partials ⚠️
.../core/src/services/credential-generator.service.ts 85.71% 1 Missing ⚠️
...ols/send/send-ui/src/send-form/send-form.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11816      +/-   ##
==========================================
- Coverage   33.53%   33.51%   -0.02%     
==========================================
  Files        2814     2817       +3     
  Lines       87475    87602     +127     
  Branches    16676    16698      +22     
==========================================
+ Hits        29332    29361      +29     
- Misses      55836    55931      +95     
- Partials     2307     2310       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov