[PM-13876] Generator PR review follow up

[djsmith85]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13876

📔 Objective

As mentioned on #11816, this is a follow-up to removed some smaller nits from my review of #11816.

• Remove unused regex - 21f929a
  • [PM-13876] replace angular validation with html constraints validation #11816 (comment)
• Remove viewChild reference from markup - 3dc92e0
  • [PM-13876] replace angular validation with html constraints validation #11816 (comment)

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.61%. Comparing base (4cc562c) to head (3dc92e0).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11885      +/-   ##
==========================================
- Coverage   33.62%   33.61%   -0.01%     
==========================================
  Files        2823     2823              
  Lines       88176    88180       +4     
  Branches    16798    16799       +1     
==========================================
- Hits        29647    29644       -3     
- Misses      56207    56214       +7     
  Partials     2322     2322              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 3f02d107-73e7-4f86-810c-96c7931ddb7c

No New Or Fixed Issues Found