Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13455] - final data aggregation for risk insights #12012

Closed
wants to merge 5 commits into from

Conversation

jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Nov 15, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13455

📔 Objective

This PR aggregates the member cipher details with the organization ciphers to create a report of all apps which have at-risk ciphers. It also removes the Raw Data, Raw Data + members, and Raw Data + members uri tabs as they were meant to be temporary.

📸 Screenshots

Screenshot 2024-11-14 at 5 42 07 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner November 15, 2024 01:42
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Logo
Checkmarx One – Scan Summary & Details3760dacd-c453-4e9d-884b-4f59b9abf6fd

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 40 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 50
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 50
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 55
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 35
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 50
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45
MEDIUM Client_Privacy_Violation /libs/vault/src/components/totp-countdown/totp-countdown.component.ts: 14
MEDIUM Client_Privacy_Violation /libs/vault/src/components/totp-countdown/totp-countdown.component.ts: 15
LOW Angular_Usage_of_Unsafe_DOM_Sanitizer /libs/components/src/avatar/avatar.component.ts: 80
LOW Angular_Usage_of_Unsafe_DOM_Sanitizer /apps/desktop/src/app/components/avatar.component.ts: 75
LOW Client_Hardcoded_Domain /apps/web/src/app/billing/shared/payment/payment.component.ts: 73
LOW Client_Hardcoded_Domain /apps/web/src/app/billing/shared/payment/payment.component.ts: 73
LOW Client_JQuery_Deprecated_Symbols /libs/importer/src/services/import.service.ts: 467
LOW Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 47

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 20.43011% with 74 lines in your changes missing coverage. Please review.

Project coverage is 33.39%. Comparing base (d55c871) to head (2ffe31d).
Report is 261 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../risk-insights/services/password-health.service.ts 18.91% 60 Missing ⚠️
.../access-intelligence/all-applications.component.ts 0.00% 8 Missing ⚠️
...ess-intelligence/applications-loading.component.ts 0.00% 5 Missing ⚠️
...ss-intelligence/critical-applications.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12012      +/-   ##
==========================================
- Coverage   33.48%   33.39%   -0.09%     
==========================================
  Files        2846     2863      +17     
  Lines       89214    89533     +319     
  Branches    17006    17054      +48     
==========================================
+ Hits        29872    29904      +32     
- Misses      56989    57282     +293     
+ Partials     2353     2347       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaasen-livefront
Copy link
Collaborator Author

Closing in favor of #12071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant