Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth/PM-15155 - 2FA Component Renames #12092

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JaredSnider-Bitwarden
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden commented Nov 21, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15155

📔 Objective

To refactor the names of our 2FA setup components to clarify the difference between the 2FA method setup components and the 2FA method implementation components. See commits for step by step naming conversion.

📸 Screenshots

n/a

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 33.42%. Comparing base (9e9f977) to head (cc64969).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../settings/two-factor/two-factor-setup.component.ts 50.00% 5 Missing ⚠️
...ganizations/settings/two-factor-setup.component.ts 0.00% 4 Missing ⚠️
.../auth/settings/security/security-routing.module.ts 0.00% 1 Missing ⚠️
...factor/two-factor-setup-authenticator.component.ts 66.66% 1 Missing ⚠️
...tings/two-factor/two-factor-setup-duo.component.ts 66.66% 1 Missing ⚠️
...ngs/two-factor/two-factor-setup-email.component.ts 66.66% 1 Missing ⚠️
.../two-factor/two-factor-setup-webauthn.component.ts 66.66% 1 Missing ⚠️
...s/two-factor/two-factor-setup-yubikey.component.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12092   +/-   ##
=======================================
  Coverage   33.42%   33.42%           
=======================================
  Files        2871     2871           
  Lines       89811    89811           
  Branches    17103    17103           
=======================================
+ Hits        30016    30023    +7     
+ Misses      57433    57426    -7     
  Partials     2362     2362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details7e59a9c7-9579-474e-bf52-965cdf301139

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants