Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15840] When org reaches collection limit, organization upgrade pa… #12648

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

jonashendrickx
Copy link
Member

…ge infinitely loads.

🎟️ Tracking

PM-15840

📔 Objective

There was a race condition between the route parameter and the query parameter in addition to being them both in the wrong order.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

jonashendrickx and others added 3 commits December 11, 2024 14:01
…ed-max-collection-count-clicking-Upgrade-button-navigates-to-a-spinning-Subscription-page
@jonashendrickx jonashendrickx requested a review from a team as a code owner January 1, 2025 16:36
@jonashendrickx jonashendrickx added the needs-qa Marks a PR as requiring QA approval label Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

Logo
Checkmarx One – Scan Summary & Details5993d74d-e975-4594-a209-acd8e9a7c725

No New Or Fixed Issues Found

@github-actions github-actions bot temporarily deployed to Web Vault - EU QA Cloud January 8, 2025 13:11 Inactive
@jonashendrickx jonashendrickx removed the needs-qa Marks a PR as requiring QA approval label Jan 9, 2025
@jonashendrickx jonashendrickx enabled auto-merge (squash) January 9, 2025 07:45
@jonashendrickx jonashendrickx merged commit aec25b1 into main Jan 9, 2025
36 of 37 checks passed
@jonashendrickx jonashendrickx deleted the PM-15840 branch January 9, 2025 07:53
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 34.14%. Comparing base (5c96634) to head (7f0e219).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tions/organization-subscription-cloud.component.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12648   +/-   ##
=======================================
  Coverage   34.14%   34.14%           
=======================================
  Files        2937     2937           
  Lines       90341    90341           
  Branches    16964    16964           
=======================================
  Hits        30846    30846           
  Misses      57040    57040           
  Partials     2455     2455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants