Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16928] Fix bad imports #12805

Merged
merged 2 commits into from
Jan 10, 2025
Merged

[PM-16928] Fix bad imports #12805

merged 2 commits into from
Jan 10, 2025

Conversation

vincentsalucci
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16928

📔 Objective

Update imports to remove any src relative file path reference in preparation for upcoming module changes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vincentsalucci vincentsalucci requested a review from Hinton January 10, 2025 15:25
@vincentsalucci vincentsalucci self-assigned this Jan 10, 2025
@vincentsalucci vincentsalucci requested a review from a team as a code owner January 10, 2025 15:25
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Logo
Checkmarx One – Scan Summary & Details575b716c-2953-4ecf-bb47-d24551afd458

No New Or Fixed Issues Found

@Hinton Hinton added the hold do not merge, do not approve yet label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.13%. Comparing base (b8f57f3) to head (874c76a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12805   +/-   ##
=======================================
  Coverage   34.13%   34.13%           
=======================================
  Files        2936     2936           
  Lines       90433    90433           
  Branches    16989    16989           
=======================================
  Hits        30869    30869           
  Misses      57107    57107           
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton removed the hold do not merge, do not approve yet label Jan 10, 2025
JimmyVo16
JimmyVo16 previously approved these changes Jan 10, 2025
@vincentsalucci vincentsalucci merged commit 3c99493 into main Jan 10, 2025
33 checks passed
@vincentsalucci vincentsalucci deleted the ac/pm-16928/fix-bad-imports branch January 10, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants