PM-14051-storybook-implementation #12840
Merged
+637
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Initial stories and folder structure
|
Fixed Issues (173)Great job! The following issues were fixed in this Pull Request
|
…ix folder structure to set prep for doc creation
jprusik
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14051
📔 Objective
Currently, our instance of Storybook does not support rendering Lit components. To address this, a temporary separate instance of Storybook has been created specifically for Lit component stories. This setup will remain in place until the two instances can be merged into a single, unified environment.
To ensure the current Storybook instance retains its original functionality without interference, the Lit component stories have been named with the
.lit-stories.tssuffix, deviating from the usual.storiesnaming convention. This approach allows each Storybook instance to exclusively recognize its intended set of stories.Additionally, each story has been organized into its own directory within a dedicated stories folder. This structure is designed to facilitate the addition of documentation for each story in an upcoming PR.
Note: Followed docs for SB and was required to add web components package.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes