Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17047] Bugfix: Change clientType expression to assignment #12865

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

rr-bw
Copy link
Contributor

@rr-bw rr-bw commented Jan 14, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17047

📔 Objective

Bugfix: Switches an expression to an assignment. This would only effect the create new user flows, so I've added videos of all of those below.

📸 Screenshots

Web

web.mov

Extension

browser.mov

Desktop

desktop.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@rr-bw rr-bw marked this pull request as ready for review January 14, 2025 17:32
@rr-bw rr-bw requested a review from a team as a code owner January 14, 2025 17:32
@rr-bw rr-bw requested a review from ike-kottlowski January 14, 2025 17:32
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.28%. Comparing base (f44b36b) to head (7ddf2db).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tion-options/login-decryption-options.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12865   +/-   ##
=======================================
  Coverage   34.28%   34.28%           
=======================================
  Files        2934     2934           
  Lines       90225    90225           
  Branches    16944    16944           
=======================================
  Hits        30937    30937           
  Misses      56824    56824           
  Partials     2464     2464           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details976a3c78-0b1c-4811-8925-101f0ceb7b06

Great job, no security vulnerabilities found in this Pull Request

@rr-bw rr-bw merged commit 27e8a1f into main Jan 14, 2025
84 checks passed
@rr-bw rr-bw deleted the auth/pm-17047/fix-client-type-assignment branch January 14, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants