Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16898] remove jslib services #12873

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −16
Draft

[PM-16898] remove jslib services #12873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions libs/tools/generator/components/src/credential-generator-history-dialog.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { Component } from "@angular/core";
import { takeUntilDestroyed } from "@angular/core/rxjs-interop";
import { BehaviorSubject, distinctUntilChanged, firstValueFrom, map, switchMap } from "rxjs";

import { JslibModule } from "@bitwarden/angular/jslib.module";
import { AccountService } from "@bitwarden/common/auth/abstractions/account.service";
import { UserId } from "@bitwarden/common/types/guid";
import { ButtonModule, DialogModule, DialogService } from "@bitwarden/components";
Expand All @@ -21,7 +20,6 @@ import { EmptyCredentialHistoryComponent } from "./empty-credential-history.comp
imports: [
ButtonModule,
CommonModule,
JslibModule,
DialogModule,
CredentialGeneratorHistoryToolsComponent,
EmptyCredentialHistoryComponent,
Expand Down
8 changes: 0 additions & 8 deletions libs/tools/generator/components/src/credential-generator-history.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,15 @@
import { CommonModule } from "@angular/common";
import { Component } from "@angular/core";
import { takeUntilDestroyed } from "@angular/core/rxjs-interop";
import { RouterLink } from "@angular/router";
import { BehaviorSubject, distinctUntilChanged, map, switchMap } from "rxjs";

import { JslibModule } from "@bitwarden/angular/jslib.module";
import { AccountService } from "@bitwarden/common/auth/abstractions/account.service";
import { UserId } from "@bitwarden/common/types/guid";
import {
ColorPasswordModule,
IconButtonModule,
ItemModule,
NoItemsModule,
SectionComponent,
SectionHeaderComponent,
} from "@bitwarden/components";
import { CredentialGeneratorService } from "@bitwarden/generator-core";
import { GeneratedCredential, GeneratorHistoryService } from "@bitwarden/generator-history";
Expand All @@ -31,11 +27,7 @@ import { GeneratorModule } from "./generator.module";
CommonModule,
IconButtonModule,
NoItemsModule,
JslibModule,
RouterLink,
ItemModule,
SectionComponent,
SectionHeaderComponent,
GeneratorModule,
],
})
Expand Down
3 changes: 1 addition & 2 deletions libs/tools/generator/components/src/empty-credential-history.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Component } from "@angular/core";

import { JslibModule } from "@bitwarden/angular/jslib.module";
import { IconModule, TypographyModule } from "@bitwarden/components";

import { NoCredentialsIcon } from "./icons/no-credentials.icon";
Expand All @@ -9,7 +8,7 @@ import { NoCredentialsIcon } from "./icons/no-credentials.icon";
standalone: true,
selector: "bit-empty-credential-history",
templateUrl: "empty-credential-history.component.html",
imports: [JslibModule, IconModule, TypographyModule],
imports: [IconModule, TypographyModule],
})
export class EmptyCredentialHistoryComponent {
noCredentialsIcon = NoCredentialsIcon;
Expand Down
2 changes: 0 additions & 2 deletions libs/tools/generator/components/src/generator-services.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { NgModule } from "@angular/core";

import { JslibModule } from "@bitwarden/angular/jslib.module";
import { safeProvider } from "@bitwarden/angular/platform/utils/safe-provider";
import { SafeInjectionToken } from "@bitwarden/angular/services/injection-tokens";
import { ApiService } from "@bitwarden/common/abstractions/api.service";
Expand All @@ -22,7 +21,6 @@ export const RANDOMIZER = new SafeInjectionToken<Randomizer>("Randomizer");

/** Shared module containing generator component dependencies */
@NgModule({
imports: [JslibModule],
providers: [
safeProvider({
provide: RANDOMIZER,
Expand Down
2 changes: 0 additions & 2 deletions libs/tools/generator/components/src/generator.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { CommonModule } from "@angular/common";
import { NgModule } from "@angular/core";
import { ReactiveFormsModule } from "@angular/forms";

import { JslibModule } from "@bitwarden/angular/jslib.module";
import {
CardComponent,
ColorPasswordModule,
Expand Down Expand Up @@ -41,7 +40,6 @@ import { UsernameSettingsComponent } from "./username-settings.component";
IconButtonModule,
InputModule,
ItemModule,
JslibModule,
ReactiveFormsModule,
SectionComponent,
SectionHeaderComponent,
Expand Down
Loading