[PM-16245] delete btn in browser edit item

[Jingo88]

🎟️ Tracking

PM-16245
PM-17134 - toast bug

📔 Objective

• Added the Trash icon delete button to the browser edit item page
• Delete icon is only available for items with Can Manage permissions
• Delete icon will not show for any lower permissions, as well as new item views
• Delete will navigate back to the vault page with filters persisted

📸 Screen Recording

PM-16245.mov

Adding screen recording of fixed toast success copy

PM-17134.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – c5391248-b861-4bd1-8487-afb9b2b8ea4d

New Issues (10)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	Client_Privacy_Violation	/libs/angular/src/admin-console/components/collections.component.ts: 36	details Method at line 36 of /libs/angular/src/admin-console/components/collections.component.ts sends user information outside the application. This may ... Attack Vector
	Client_Privacy_Violation	/libs/angular/src/vault/components/add-edit.component.ts: 119	details Method at line 119 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application. This may constitute... Attack Vector
	Client_Privacy_Violation	/libs/angular/src/vault/components/add-edit.component.ts: 286	details Method load at line 286 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application. This may consti... Attack Vector
	Client_Privacy_Violation	/libs/angular/src/vault/components/add-edit.component.ts: 780	details Method loadAddEditCipherInfo at line 780 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.component.ts: 50	details Method OpenAttachmentsComponent at line 50 of /apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.compo... Attack Vector
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.component.ts: 50	details Method at line 50 of /apps/browser/src/vault/popup/components/vault-v2/attachments/open-attachments/open-attachments.component.ts sends user infor... Attack Vector
	Client_Privacy_Violation	/libs/angular/src/vault/components/add-edit.component.ts: 70	details Method at line 70 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application. This may constitute ... Attack Vector
	Client_Privacy_Violation	/libs/angular/src/vault/components/add-edit.component.ts: 278	details Method load at line 278 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application. This may consti... Attack Vector
	Client_Privacy_Violation	/libs/angular/src/vault/components/add-edit.component.ts: 776	details Method loadAddEditCipherInfo at line 776 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application... Attack Vector
	Client_Privacy_Violation	/libs/angular/src/vault/components/add-edit.component.ts: 281	details Method load at line 281 of /libs/angular/src/vault/components/add-edit.component.ts sends user information outside the application. This may consti... Attack Vector

[codecov]

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Project coverage is 35.11%. Comparing base (ba4d762) to head (92aabe7).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ponents/vault-v2/add-edit/add-edit-v2.component.ts	61.90%	4 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12876      +/-   ##
==========================================
- Coverage   35.19%   35.11%   -0.08%     
==========================================
  Files        2992     2990       -2     
  Lines       90675    91097     +422     
  Branches    16964    17058      +94     
==========================================
+ Hits        31911    31991      +80     
- Misses      56300    56608     +308     
- Partials     2464     2498      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nick-livefront]

👏 Love some good tests 👏

[nick-livefront]

✅

[gbubemismith]

LGTM