Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13989] - Extension Vault screen - allow copy icon to copy data directly if only 1 piece of data is available #13520

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13989

📔 Objective

This PR updates the vault item copy button to immediately copy if the vault item only has a single field with a value.

📸 Screenshots

Screen.Recording.2025-02-21.at.5.14.57.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 35.60%. Comparing base (657902c) to head (2b11013).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...v2/item-copy-action/item-copy-actions.component.ts 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13520      +/-   ##
==========================================
+ Coverage   35.30%   35.60%   +0.29%     
==========================================
  Files        3137     3141       +4     
  Lines       92936    93092     +156     
  Branches    16891    16927      +36     
==========================================
+ Hits        32815    33149     +334     
+ Misses      57664    57406     -258     
- Partials     2457     2537      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsd62292a7-72db-4a4a-926b-23bd10318692

Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
HIGH Client_DOM_XSS /apps/web/src/connectors/sso.ts: 30
HIGH Client_DOM_XSS /apps/web/src/connectors/sso.ts: 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant