[PM-18549] Do not clear route or view persistence on tab change #13523
+5
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trmartin4
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13523 +/- ##
=======================================
Coverage 35.60% 35.60%
=======================================
Files 3141 3141
Lines 93079 93070 -9
Branches 16925 16924 -1
=======================================
- Hits 33142 33141 -1
+ Misses 57400 57392 -8
Partials 2537 2537 ☔ View full report in Codecov by Sentry. |
|
|
Great job, no security vulnerabilities found in this Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-18549
📔 Objective
In order to support using extension route persistence for login flows that require the user to go to their email inbox or another tab to perform the operation, we need to remove the restriction that cleared the cache on tab change.
Examples of user flows that would require this are:
Note that I also removed the TS strict comment from this file while I was modifying it.
📸 Screenshots
persist_through_tab_change.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes