[PM-19471] Update Rust windows crate to 0.61.1 #13974
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #13974 +/- ##
==========================================
- Coverage 36.67% 36.67% -0.01%
==========================================
Files 3180 3180
Lines 92528 92528
Branches 16692 16692
==========================================
- Hits 33939 33932 -7
- Misses 56034 56041 +7
Partials 2555 2555 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job, no security vulnerabilities found in this Pull Request |
| @@ -23,6 +23,6 @@ pub fn focus_security_prompt() { | |||
| pub(crate) fn set_focus(window: HWND) { | |||
| unsafe { | |||
| let _ = SetForegroundWindow(window); | |||
| let _ = SetFocus(window); | |||
| let _ = SetFocus(Some(window)); | |||
There was a problem hiding this comment.
For qa: We have an existing bug, when called from a browser (chrome/firefox), the focusing does not work on windows. Even if this changes that code, feel free to have QA disregard if they note this behavior as a bug.
There was a problem hiding this comment.
Thanks for the heads up!
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-19471
📔 Objective
The goals of this PR are:
windowscrate indesktop_nativeto0.61.1I wanted to update to
0.60.0, but it seems in thewindowscrate0.60.0release,IAsyncOperationhad been removed. I'm not sure why? I could be missing something here.IAsyncOperationnow resides in the windows-future crate. So, this seems to be a newly required crate if we want to keep up with updates.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes