[PM-17514] Remove old add-edit components #13984
Open
+0
−1,773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also removes the individual vault add-edit-component where the custom fields component was used - All of these components were unused
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #13984 +/- ##
==========================================
+ Coverage 36.28% 36.31% +0.02%
==========================================
Files 3186 3183 -3
Lines 92951 92719 -232
Branches 16844 16765 -79
==========================================
- Hits 33728 33669 -59
+ Misses 56615 56488 -127
+ Partials 2608 2562 -46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
Great job, no security vulnerabilities found in this Pull Request |
addisonbeck
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-17514
📔 Objective
The ticket is oriented to remove the old and unused
add-edit-custom-fieldscomponents.NOTE: The desktop app is still using old components but are being migrated PM-18520. I will keep this ticket open until that migration is complete and the old components can be removed.
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes