Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-19398] managed environment not displayed on browser client #13997

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alec-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19398?atlOrigin=eyJpIjoiY2M3OGVlNTBjOThiNDQ2ZWEzNWI3ZmQ5NWQ0YjY1MDAiLCJwIjoiaiJ9

📔 Objective

Populate self-hosted environment settings with managed environment settings when available.

📸 Screenshots

GMT20250326-012342_Clip_Alec.Rippberger.s.Clip.03_25_2025.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 36.66%. Comparing base (51bfbcf) to head (12f5e57).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-dialog/self-hosted-env-config-dialog.component.ts 0.00% 15 Missing ⚠️
...c/platform/services/browser-environment.service.ts 0.00% 4 Missing ⚠️
...ps/web/src/app/platform/web-environment.service.ts 0.00% 1 Missing ⚠️
...c/platform/services/default-environment.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13997      +/-   ##
==========================================
- Coverage   36.67%   36.66%   -0.01%     
==========================================
  Files        3180     3180              
  Lines       92528    92534       +6     
  Branches    16692    16696       +4     
==========================================
- Hits        33939    33932       -7     
- Misses      56034    56047      +13     
  Partials     2555     2555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1da88734-c84a-4845-925c-720115c33557

Great job, no security vulnerabilities found in this Pull Request

@JaredSnider-Bitwarden JaredSnider-Bitwarden changed the title [PM-19398] managed environement not displayed on browser client [PM-19398] managed environment not displayed on browser client Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant