[deps]: Update electron to v33 #658
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
bitwarden-bot
changed the title
|
Internal tracking:
|
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/electron-33.x
branch
from
0bb2245
to
9c3f843
Compare
renovate
bot
force-pushed
the
renovate/electron-33.x
branch
from
9c3f843
to
d17c9f5
Compare
There was a problem hiding this comment.
This upgrade breaks the electron build. Something introduced in v32.2.0 results in the following error during the build:
ERROR in /directory-connector/jslib/electron/src/tray.main.ts(63,12) TS2769: No overload matches this call. The last overload gave the following error. Argument of type '"minimize"' is not assignable to parameter of type '"will-resize"'.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
=====================================
Coverage 2.24% 2.24%
=====================================
Files 60 60
Lines 2633 2633
Branches 467 467
=====================================
Hits 59 59
Misses 2571 2571
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
| @@ -60,9 +60,8 @@ export class TrayMain { | |||
| } | |||
|
|
|||
| setupWindowListeners(win: BrowserWindow) { | |||
| win.on("minimize", async (e: Event) => { | |||
There was a problem hiding this comment.
Electron updated their type definitions for these event handler overloads. This overload's params were changed from accepting a Function definition to an arrow function with no parameters.
|
Adding @eliykat for a second set of eyes. Do you think this is alright to merge with the fix I added? TBH, I don't know if this is even working as intending in the first place considering I don't see anything in the tray when I minimize the app build from main. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
28.3.3->33.2.0Release Notes
electron/electron (electron)
v33.2.0: electron v33.2.0Compare Source
Release Notes for v33.2.0
Features
Other Changes
v33.1.0: electron v33.1.0Compare Source
Release Notes for v33.1.0
Features
WebFrameMain.detachedfor frames in an unloading state.WebFrameMain.isDestroyed()to determine if a frame has been destroyed.webFrameMain.fromId(processId, frameId)returning aWebFrameMaininstance which doesn't match the given parameters when the frame is unloading. #44209Fixes
EventSourcewasundefinedin both renderer and worker processes when Node.js integration was enabled. #44496 (Also in 32, 34)libgdk_pixbuf. #44436 (Also in 32, 34)Other Changes
v33.0.2: electron v33.0.2Compare Source
Release Notes for v33.0.2
Fixes
trace-startupnot working on macOS. #44276 (Also in 32, 34)exitevent could be emitted twice from theutilityProcess. #44266 (Also in 31, 32, 34)v33.0.1: electron v33.0.1Compare Source
Release Notes for v33.0.1
Other Changes
v33.0.0: electron v33.0.0Compare Source
Release Notes for 33.0.0
Stack Upgrades
130.0.6723.4420.18.013.0Breaking Changes
texturedBrowserWindowtypeoption on macOS. #43133protocol.registerFileProtocoland thebaseURLForDataURLproperty onBrowserWindow.loadURL,WebContents.loadURL, and<webview>.loadURL. #43977Features
Additions
app.setClientCertRequestPasswordHandler(handler), to help unlock cryptographic devices when a PIN is needed. #41205View.setBorderRadius(radius)for customizing the border radius of views—with compatibility forWebContentsView. #42320desktopCapturerandsetDisplayMediaRequestHandler. #43680 (Also in 32)DownloadItem.getCurrentBytesPerSecond(),DownloadItem.getPercentComplete(),DownloadItem.getEndTime(). #42805 (Also in 30, 31, 32)prefersReducedTransparencytonativeTheme, which indicates whether the user has chosen to reduce OS-level transparency via system accessibility settings. #42862 (Also in 30, 31, 32)app#loginevent. #42631 (Also in 32)Improvements
navigationHistoryAPI with 2 new functions for better history management. #42014sender-idhint is set when creating desktop notifications on DBus. #43949 (Also in 31, 32)systemPreferencestoutilityProcess. #42203 (Also in 30, 31, 32)Fixes
enable_pluginsbuild flag is false. #44025Also in earlier versions...
MenuItem.clickhandler not settingfocusedWindowparameter when focused window is aBaseWindow. #43438 (Also in 31, 32)focuson aWebView'swebContents. #43932 (Also in 31, 32)BrowserWindow.setTopBrowserView. #42653 (Also in 30, 31, 32)webContents.close()on a BrowserView. #42633 (Also in 31, 32)setWindowOpenHandler. #43816 (Also in 31, 32)postMessage. #42535 (Also in 30, 31, 32)BaseWindow.setTouchBardidn't work as expected. #43422 (Also in 30, 31, 32)WebContentsViews did not show correctly in some circumstances on macOS after being added as child views. #43696 (Also in 31, 32)defaultPathdid not work for all users on Linux when creating an open file dialog. #43595 (Also in 30, 31, 32)fetch-dependent interfaces could be missing in Web Workers withnodeIntegrationInWorkerenabled. #42579 (Also in 30, 31, 32)navigator.mediaDevices.enumerateDevicescould return broken results in some cases after callingsession.setPermissionCheckHandler. #42775 (Also in 30, 31, 32)navigator.mediaDevices.getUserMediaandnavigator.getUserMediashould reject with aNotAllowedErrorif microphone or camera permissions have been denied at the system level on macOS. #42899 (Also in 30, 31, 32)navigator.serial.getPorts()incorrectly returned an empty array in some cases. #43101 (Also in 30, 31, 32)system-context-menuwas not triggered as expected on Windows when using a frameless BrowserWindow. #43243 (Also in 30, 31, 32)BrowserWindow.setBackgroundColorwith some level of transparency could cause a crash. #42824 (Also in 31, 32)desktopCapturer.getSourceson macOS running 14.4 or later would make non-resizable windows resizable. #43013 (Also in 31, 32)window.print(),webContents.print()orprintToPDFfrom an existing PDF document resulted in a blank page. #43309 (Also in 31, 32)window.showInactiveon macOS did not actually show the window. #43079 (Also in 31, 32)desktopCapturerAPI andscreen.getAllDisplays()no longer matched on Windows. #42781 (Also in 31, 32)desktopCapturerAPI andscreen.getAllDisplays()no longer matched on Windows. #42883 (Also in 31, 32)resizeevents being emitted on Windows when the window was moved but not resized. #43457 (Also in 32)session.resolveProxyapi. #42878 (Also in 30, 31, 32)desktopCapturer.getSourcesnever fulfilled its promise in some cases. #43080 (Also in 29, 30, 31, 32)Content-Dispositionheader parsing. #43670 (Also in 30, 31, 32)npm run lintnot working on Windows. #42281 (Also in 31, 32)inputtag could cause a crash. #42758 (Also in 30, 31, 32)Documentation
Notices
End of Support for 30.x.y
Electron 30.x.y has reached end-of-support as per the project's support policy. Developers and applications are encouraged to upgrade to a newer version of Electron.
v32.2.3: electron v32.2.3Compare Source
Release Notes for v32.2.3
Fixes
EventSourcewasundefinedin both renderer and worker processes when Node.js integration was enabled. #44497 (Also in 33, 34)libgdk_pixbuf. #44437 (Also in 33, 34)Other Changes
v32.2.2: electron v32.2.2Compare Source
Release Notes for v32.2.2
Fixes
trace-startupnot working on macOS. #44292 (Also in 33, 34)exitevent could be emitted twice from theutilityProcess. #44268 (Also in 31, 33, 34)Other Changes
v32.2.1: electron v32.2.1Compare Source
Release Notes for v32.2.1
Fixes
Other Changes
3696306.v32.2.0: electron v32.2.0Compare Source
Release Notes for v32.2.0
Fixes
focuson aWebView'swebContents. #43934 (Also in 31, 33)setWindowOpenHandler. #43877 (Also in 31, 33)Other Changes
sender-idhint is set when creating desktop notifications on DBus. #43950 (Also in 31, 33)v32.1.2: electron v32.1.2Compare Source
Release Notes for v32.1.2
Fixes
v32.1.1: electron v32.1.1Compare Source
Release Notes for v32.1.1
Fixes
WebContentsViews did not show correctly in some circumstances on macOS after being added as child views. #43698 (Also in 31, 33)Other Changes
v32.1.0: electron v32.1.0Compare Source
Release Notes for v32.1.0
Features
desktopCapturerandsetDisplayMediaRequestHandler. #43679 (Also in 33)Fixes
defaultPathdid not work for all users on Linux when creating an open file dialog. #43629 (Also in 30, 31, 33)resizeevents being emitted on Windows when the window was moved but not resized. #43644 (Also in 33)Content-Dispositionheader parsing. #43668 (Also in 30, 31, 33)Other Changes
v32.0.2: electron v32.0.2Compare Source
Release Notes for v32.0.2
Fixes
MenuItem.clickhandler not settingfocusedWindowparameter when focused window is aBaseWindow. #43437 (Also in 31, 33)BaseWindow.setTouchBardidn't work as expected. #43421 (Also in 30, 31, 33)Other Changes
Documentation
v32.0.1: electron v32.0.1Compare Source
Release Notes for v32.0.1
Other Changes
9797576from v8 #43384v32.0.0: electron v32.0.0Compare Source
Release Notes for v32.0.0
Stack Upgrades
128.0.6613.3620.16.012.8Breaking Changes
File.pathextension from the WebFileAPI. #42053webcontents.navigationHistory:canGoBack,goBack,canGoForward,goForward,canGoToOffset,goToOffset,clear. #41752Features
Additions
DownloadItem.getCurrentBytesPerSecond(),DownloadItem.getPercentComplete(),DownloadItem.getEndTime(). #42913 (Also in 30, 31)cumulativeCPUUsageto AppMetrics and CPUUsage. #41819prefersReducedTransparencytonativeTheme, which indicates whether the user has chosen to reduce OS-level transparency via system accessibility settings. #43024 (Also in 30, 31)systemPreferencestoutilityProcess. #42599 (Also in 30, 31)Improvements
WebContentsViewto accept pre-existingwebContentsobject. #42086 (Also in 31)ses.cookies.setfails. #42362 (Also in 29, 30, 31)Fixes
Also in earlier versions...
npm run lintnot working on Windows. #42905 (Also in 31)addChildViewif a view is added as its own child. #42067 (Also in 30, 31)WebContentsViewis added viaaddChildViewmultiple times. #42085 (Also in 30, 31)BrowserWindow.setTopBrowserView. #42733 (Also in 30, 31)webContents.close()on a BrowserView. #42811 (Also in 31)setAutoResizeon aBrowserView. #42056 (Also in 30, 31)postMessage. #42581 (Also in 30, 31)BrowserViewwebContentswere getting destroyed even whenpreventDefaultwas being set on the owningBrowserWindow'scloseevent. #42353 (Also in 30, 31)app.setLoginItemSettingsincorrectly checked againstloginItemService. #42380 (Also in 29, 30, 31)contentWindow.document.fonts.readywould never resolve in some circumstances. #42366 (Also in 30, 31)document.requestFullscreendidn't work when calling it from awebContentsinsideWebContentsView. #41966 (Also in 30, 31)fetchdependent interfaces in Node.js were not defined whennodeIntegrationwas enabled in some circumstances. #42419 (Also in 30, 31)fetch-dependent interfaces could be missing in Web Workers withnodeIntegrationInWorkerenabled. #42595 (Also in 30, 31)navigator.mediaDevices.enumerateDevicescould return broken results in some cases after callingsession.setPermissionCheckHandler. #42808 (Also in 30, 31)navigator.mediaDevices.getUserMediaandnavigator.getUserMedia