Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8962] use dynamic replicas #153

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lidiams96
Copy link

This pull request introduces changes to the Bitwarden chart to allow users to configure the number of replicas for each component from the values.yaml file. By default, the number of replicas is set to one for all components. However, the Bitwarden documentation suggests increasing the number of replicas to enhance high availability, which is currently not possible with the existing configuration. This update aims to provide flexibility in setting the replica count per component directly from the values.yaml file.

Changes Made

Replicas Configuration:

  • Introduced new fields in the values.yaml file to specify the number of replicas for each component.
    Updated deployment templates to use the specified replica count from the values.yaml file instead of defaulting to one.
    Job Adaptation:

  • Modified the job configuration to consider only the state of the first container set to true. This adaptation ensures that the job correctly handles the state with the increased number of replicas.

@lidiams96 lidiams96 requested a review from a team as a code owner June 17, 2024 15:07
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-8962

@bitwarden-bot bitwarden-bot changed the title use dynamic replicas [PM-8962] use dynamic replicas Jun 17, 2024
@bitwarden-bot bitwarden-bot added in-product-review Community PR is being reviewed by Bitwarden's Product team community-pr labels Jun 17, 2024
@bitwarden-bot
Copy link

bitwarden-bot commented Jun 17, 2024

Logo
Checkmarx One – Scan Summary & Detailse8112da7-163c-4c60-9a65-792841686fa3

No New Or Fixed Issues Found

@djsmith85 djsmith85 requested a review from a team July 17, 2024 13:43
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-pr in-product-review Community PR is being reviewed by Bitwarden's Product team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants